-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix lasso unresponsive issue by adding a lock release event #25155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
@ianhi maybe you are the wrong person to ask for a review here, but feel free to suggest someone else...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd approve this (conditional on my comment about checking for ownership of the lock) as this does indeed fix the reported bug. Nice fix @devRD!
That said I think that using Lasso is something that should be discouraged in favor of lasso selector - perhaps even deprecated and removed. See my comments in #19221 for more. Still this is clear improvement and the perfect should not be the enemy of the good.
@ianhi maybe you are the wrong person to ask for a review here,
I'm probably the right person :)
Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
@ianhi Thank you for the review! I added your suggested changes.
Awesome @devRD - i think that the process is now that at least one core dev (i.e. not me) needs to approve this (only one as this is documentation).
For whoever that is I think the things to check are:
- Run the example - click once, then see that you can still lasso as expected
- Run the example make lassos as expected
full file for copy paste purposes: https://github.com/matplotlib/matplotlib/blob/418c9e7037896bea4a4db5cce656f2933014f0e0/examples/event_handling/lasso_demo.py
@ianhi you have merge rights, if I'm not mistaken.
@ianhi you have merge rights, if I'm not mistaken.
I actually don't - I think I only have the power to open/close issues+PRs and apply labels. I have merging rights over on ipympl
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
...a lock release event
Thanks @devRD! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.
...155-on-v3.7.x Backport PR #25155 on branch v3.7.x (Fix lasso unresponsive issue by adding a lock release event)
PR Summary
Fixes #25137 by adding a lock release event.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst