-
-
Notifications
You must be signed in to change notification settings - Fork 8k
[Doc] Fix spelling and grammar in tutorials #24526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unsure of the x-axis convention
e41843c to
35771d3
Compare
Got back to this now, so please have another look. Thanks for the comments!
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.6.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6649511e2b75badc2255d83e232c0f2613c90fd5
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24526: [Doc] Fix spelling and grammar in tutorials'
- Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24526-on-v3.6.x
- Create a PR against branch v3.6.x, I would have named this PR:
"Backport PR #24526 on branch v3.6.x ([Doc] Fix spelling and grammar in tutorials)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout v3.6.2-doc
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6649511e2b75badc2255d83e232c0f2613c90fd5
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24526: [Doc] Fix spelling and grammar in tutorials'
- Push to a named branch:
git push YOURFORK v3.6.2-doc:auto-backport-of-pr-24526-on-v3.6.2-doc
- Create a PR against branch v3.6.2-doc, I would have named this PR:
"Backport PR #24526 on branch v3.6.2-doc ([Doc] Fix spelling and grammar in tutorials)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst