-
-
Notifications
You must be signed in to change notification settings - Fork 8k
[DOC]: add parent link for FuncAnimation and ArtistAnimation
#24169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
I'm currently having trouble building matplotlib on my machine, and so I cannot build the docs that reflect the changes I made.
Closing and reopening to retrigger docs build. (PR looks OK, not sure what causes the CircleCI error. Happens sometimes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the doc build directly fails. Looks good though!
(I think the description is better than before, even if we provides inherited members.)
I'll merge this as I do not understand what causes the completely failed doc-build...
Thanks @kwsp and congratulations on your first merged PR in Matplotlib! Hope to see your around!
...tion` and `ArtistAnimation`
FuncAnimation and ArtistAnimation (削除ここまで)FuncAnimation and ArtistAnimation (追記ここまで)
...169-on-v3.6.x Backport PR #24169 on branch v3.6.x ([DOC]: added parent link for `FuncAnimation` and `ArtistAnimation`)
@oscargus thanks!
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
#24150 (comment)
PR Checklist
Tests and Styling
(削除) Has pytest style unit tests (andNo code changespytestpasses). (削除ここまで)flake8-docstringsand runflake8 --docstring-convention=all).Documentation
(削除) New features are documented, with examples if plot related. (削除ここまで)(削除) New features have an entry indoc/users/next_whats_new/(follow instructions in README.rst there). (削除ここまで)(削除) API changes documented indoc/api/next_api_changes/(follow instructions in README.rst there). (削除ここまで)