-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Corrected docstring for artist.Artist.set_agg_filter #23168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Can you please shorten the lines to 79 characters? (This is where linting complains.)
The ideal way is to change it, do git commit --amend (after adding the file) and then git push origin <branchname> --force-with-lease to avoid multiple commits.
7a9cdb7 to
c3803e1
Compare
@oscargus Please review.
@matplotlib/developers
Thank you @SaumyaBhushan . Congratulations on your first merged Matplotlib PR 🎉 ! Hopefully we will hear from you again.
Thanks a lot @tacaswell 🥳
...168-on-v3.5.x Backport PR #23168 on branch v3.5.x (Corrected docstring for artist.Artist.set_agg_filter)
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).#23050