-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove outdated doc for pie chart #22774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thanks for your contribution! Looks good!
I would have merged, but are unsure about the difference between the v3.5-doc and v3.5.2 tags (i.e. what v3.5-doc does). So hopefully someone that knows the difference will merge soon.
power-cycled to get the fixes on main for CI.
This needs to go against v3.5.2 as it changes the .py files in the library. The only things that can go back to the *-doc are rst files and the examples. This is because when we build the docs we install the released version and then checkout the docs branch and build from that. This makes sure the reported version is correct and we can do things like put the SHA in the docs (which obviously can not be known in the commit...because if you did you could break validation ;) (see https://shattered.io) ). We now have checks on what can be back-ported to the -doc branch.
Thank you @eagleoflqj and congratulations on your first PR in Matplotlib! Hope to see you around!
...774-on-v3.5.x Backport PR #22774 on branch v3.5.x (Remove outdated doc for pie chart)
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
After #20331 this is not valid.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).