-
-
Notifications
You must be signed in to change notification settings - Fork 8k
FIX: Colorbars check for subplotspec attribute before using #22611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the colorbar get_subplotsped() to only access attributes after a check for it having the attribute, else return None.
5 tasks
oscargus
oscargus
approved these changes
Mar 7, 2022
QuLogic
QuLogic
approved these changes
Mar 7, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 7, 2022
...tribute before using
timhoffm
added a commit
that referenced
this pull request
Mar 8, 2022
...611-on-v3.5.x Backport PR #22611 on branch v3.5.x (FIX: Colorbars check for subplotspec attribute before using)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the colorbar
get_subplotspec()to only access attributesafter a check for it having the attribute, else return None.
Fixes #22576
This will still warn about the Axes not being compatible, but I think that is expected as an AxesGrid
inset_axes()without a colorbar also warns.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).