Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Slim down animation examples in the gallery #22007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dstansby wants to merge 1 commit into matplotlib:main from dstansby:gallery-animation

Conversation

Copy link
Member

@dstansby dstansby commented Dec 19, 2021

PR Summary

This removes three animation examples from the gallery that between them take ~ 1.5 minutes to run in the doc build, but do not demonstrate Matplotlib concepts/functionality that isn't in other examples. In my opinion they are nice to have, but saving 1.5 mins on each doc CI run is a worthwhile saving. I'm probably +0.5 on it though, so if someone is keen that they stay very happy for this to be closed without merging.

Also some other minor PEP8 fixes.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

I dunno if it's a pro or con that the double pendulum & rain examples are all over the internet - a follow up might be to move these to the blog?

Copy link
Member

These also produce large output (I think unchained is actually the worst in that regard).

I would rather see the length of the animations cut down or skipped on CI (which might require work against sphinx-gallery) so save time rather than cutting them all together. I think there is a lot of value in a pretty complete application that, even though it does not show anything unique, shows how to put them together. That bit of "oooh, you can assemble the pieces like that...." spark should not be discounted.

timhoffm reacted with thumbs up emoji

Copy link
Member

jklymak commented Jan 5, 2022

Does this need discussion @dstansby, or do you have enough to work on? I'm putting back to draft given the comments above, but feel free to put back int he active queue. Thanks!

@jklymak jklymak marked this pull request as draft January 5, 2022 08:51
Copy link
Member Author

dstansby commented Jan 5, 2022

Thanks - I think there's enough to go on when I come back round to looking at this 👍

Copy link
Member Author

Since it seems like this requires higher level discussion beyond a quick PR, I'm going to close.

@dstansby dstansby deleted the gallery-animation branch February 18, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /