-
-
Notifications
You must be signed in to change notification settings - Fork 8k
DOC: replace anatomy static by new example #21928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just noticed the think grey outllne (actually already introduced in #21753). I'm not sure I like that. It's very bulky and a quite uncommon style for our figures.
The goal was to differentiate from the rest of the webpage (which is also white). We could color the whole thing but then it's a lot harder to make the little circles look good with their nice occurring effect.
I'd rather we link to the generated file rather than another new static image.
d5692f2 to
7dc6b3b
Compare
Sure, replaced by a link. That way when the example gets updated, this image will also.
Unfortunately, it looks like you can't link the 2x image because some builds need to run without them. Maybe we can expand image-sg to allow this, but we'll have to do the 1x image for now.
Or have a static.
7dc6b3b to
dfda45c
Compare
Changed back to hi-res static since the hi-res is not always generated by sphinx-gallery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, CircleCI is not happy:
/home/circleci/project/doc/tutorials/introductory/quick_start.rst:96: WARNING: image file not readable: _images/sphx_glr_anatomy_001_2_0x.png
dfda45c to
f3153e7
Compare
f3153e7 to
0b19ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct now. I'll temporarily block because I have some idea concerning the figure border that I want to try out. Will get back within 1-2 days.
I've done some formatting improvements in #22206. That should be checked and possibly included before adding a new static image.
Lets close and just put the static image in #22206. That saves me having to sync this up with whatever happens there.
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
The anatomy of figure example was changed in #21753, but I forgot to update the static version of this for including in other tutorials.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).