Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

DOC: Code from markevery_prop_cycle moved to test. #21871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 8 commits into matplotlib:main from ojeda-e:issue21863
Dec 7, 2021

Conversation

Copy link
Contributor

@ojeda-e ojeda-e commented Dec 6, 2021

PR Summary

Fixes #21863
Code from markevery_prop_cycle moved to unit test in test_lines.py. The new unit test, test_markevery_prop_cycle, uses @check_figures_equal as suggested by @timhoffm.

To make the unit test more readable and shorter I added.

  • Fixture including the cases.
  • Color list from colormap.

Thanks!

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've added some suggestions.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

One final thing, please delete examples/lines_bars_and_markers/markevery_prop_cycle.py.

ojeda-e reacted with thumbs up emoji
Copy link
Member

We reference the example from the whats new

/home/circleci/project/doc/users/prev_whats_new/whats_new_3.0.rst:110: WARNING: unknown document: /gallery/lines_bars_and_markers/markevery_prop_cycle

I suspect the best solution here is to edit the (old) whats new to remove the reference.
timhoffm reacted with thumbs up emoji

@tacaswell tacaswell modified the milestones: v3.5.1, v3.6.0 Dec 6, 2021
Copy link
Contributor Author

ojeda-e commented Dec 6, 2021

Thanks @tacaswell, deleted the reference in /doc/users/prev_whats_new/whats_new_3.0.rst.

@timhoffm timhoffm merged commit 8d85a71 into matplotlib:main Dec 7, 2021
Copy link
Member

timhoffm commented Dec 7, 2021

Thanks @ojeda-e, and congratulations on your first contribution to Matplotlib! We'd be happy to see you back!
ojeda-e and tacaswell reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Doc]: Remove example "prop_cycle property markevery in rcParams"

AltStyle によって変換されたページ (->オリジナル) /