-
-
Notifications
You must be signed in to change notification settings - Fork 8k
FIX: pre-composite animation frames to white background #21831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rothn
commented
Oct 20, 2022
Keep up the great work!
This fixes issues with encoding that do not support transparency and when the Figure facecolor is transparent. Closes matplotlib#19040
@tacaswell
tacaswell
force-pushed
the
fix_transparent_animation
branch
from
October 20, 2022 17:05
faf45b4 to
100d004
Compare
@tacaswell
tacaswell
force-pushed
the
fix_transparent_animation
branch
from
October 21, 2022 20:16
6467046 to
b0f7a18
Compare
timhoffm
timhoffm
approved these changes
Nov 4, 2022
QuLogic
QuLogic
reviewed
Nov 17, 2022
We no longer just hold onto the savefig kwargs passed in from the user so adjust test to make sure the user values go through rather than simple dictionary equality. Set the rcparam to cover all of the lines added Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@tacaswell
tacaswell
force-pushed
the
fix_transparent_animation
branch
from
November 19, 2022 22:44
8aeed7d to
a4e3cf3
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with encoding that do not support transparency and when the
Figure facecolor is transparent.
Closes #19040
PR Summary
I'm not sure how to test this as it is a visual thing is h254 encoded output.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).