-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix ConciseDateFormatter offset during zoom #21785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
dstansby
approved these changes
Nov 28, 2021
@jklymak
jklymak
changed the title
(削除) Fix concise offset zoom (削除ここまで)
(追記) Fix ConciseDateFormatter offset during zoom (追記ここまで)
Nov 29, 2021
@jklymak
jklymak
added
PR: bugfix
Pull requests that fix identified bugs
topic: date handling
labels
Nov 29, 2021
QuLogic
QuLogic
approved these changes
Nov 29, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 29, 2021
QuLogic
added a commit
that referenced
this pull request
Nov 30, 2021
...785-on-v3.5.x Backport PR #21785 on branch v3.5.x (Fix ConciseDateFormatter offset during zoom)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #21670
When plotting > 1year with concisedateformatter, no offset text is shown,. However, when you zoom it should be shown. However, we were hard-fixing the parameter for the locator, and it didn't reset itself. This PR fixes the zooming and adds a test to fix this.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).