-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add \dddot and \ddddot as accents in mathtext #20605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add \dddot and \ddddot as accents in mathtext #20605
Conversation
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Can you squash the commits (possibly splitting out the --keep-going patch)? Otherwise looks good to me, can be merged after CI completes and squashing (or not) is decided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see above)
@danzimmerman if you are not comfortable squashing (though I imagine you are given the technical needs of this change), let us know and we can just squash merge on our end.
@danzimmerman if you are not comfortable squashing (though I imagine you are given the technical needs of this change), let us know and we can just squash merge on our end.
@jklymak I'm not so familiar with squashing commits, and it looks like I complicated things by updating my branch from master
while I was working (in my history now there are many interleaved commits).
I reverted the --keep-going
in make.bat
. If it's easy to squash merge it, please go ahead!
I've squash-merged.
Thanks @danzimmerman and congratulations on your first contribution to Matplotlib! Hope to see you again.
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
This is an experiment to address and discuss #20595
Note that
dddot
andddddot
were already defined as 8411 and 8412 intex2uni
in_mathtext_data.py
, I added them again ascombiningthreedotsabove
andcombiningfourdotsabove
.This PR also added a
--keep-going
flag inmake.bat
so I could build the documentation on Windows. I should probably raise that in a separate issue/PR.Before, Mathtext Mode
dddot_before
After, Mathtext Mode
dddot_after
LaTeX vs. Mathtext Tests
With the right packages included, this works fine with
usetex=True
:usetex=True
on the top, Mathtext mode on the bottom:image
PR Checklist
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).