-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Remove remaining 3.3 deprecations #20465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
981040d to
f0aa57b
Compare
OK, there are actually two more left, the global colour map dictionary, and global cmap modification. The latter is marked for removal in 3.6, but I'm not sure about the former.
Also, the cbook.get_sample_data deprecation never mentioned a removal version...
I think get_sample_data can just get its message tweaked and behavior change postponed for one version? It's not as if anything was urgent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO for clarity, we should take the effort and make full sentences. Also in the following bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lazier here because a) this is in the removal section, so it's implied, and b) I re-edit these when I put together final release notes and they may or may not be re-grouped, and then will get an overall sentence then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0aa57b to
b04f1a3
Compare
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).