Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create error surface gradient descent plot example #20156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vitorglemos wants to merge 2 commits into matplotlib:master from vitorglemos:patch-1
Closed

Create error surface gradient descent plot example #20156

vitorglemos wants to merge 2 commits into matplotlib:master from vitorglemos:patch-1

Conversation

Copy link

@vitorglemos vitorglemos commented May 4, 2021

This example shows how to plot an error surface for the descending gradient using matplotlib.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This example shows how to plot an error surface for the descending gradient using matplotlib.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Update for compatibility with matplotlib 3.4.1
Copy link
Member

jklymak commented May 4, 2021

Thanks for the PR!

We have lots of examples, so we have to be a bit finicky about what we include. I wouldn't call this a statistics plot per-se; the statistics are all pre-plot, and frankly they are a little mysterious (don't worry I understand the underlying method, but I'm not sure how I'd understand it from this example). After that, I'm not sure it offers anything unique from the other 3-D plots already in the examples?

Copy link
Author

Thanks for the PR!

We have lots of examples, so we have to be a bit finicky about what we include. I wouldn't call this a statistics plot per-se; the statistics are all pre-plot, and frankly they are a little mysterious (don't worry I understand the underlying method, but I'm not sure how I'd understand it from this example). After that, I'm not sure it offers anything unique from the other 3-D plots already in the examples?

Hello, you are right about that! Thanks for answering me!

@jklymak jklymak marked this pull request as draft May 12, 2021 15:01
@jklymak jklymak added status: needs revision status: needs clarification Issues that need more information to resolve. labels May 12, 2021
Copy link
Member

jklymak commented May 12, 2021

@vitorglemos Did you think this was unique enough to be in the gallery? Or did you just think this was useful, and wanted to share? Thanks!

Copy link
Author

@vitorglemos Did you think this was unique enough to be in the gallery? Or did you just think this was useful, and wanted to share? Thanks!

I thought the example could be useful for the statistics examples, but maybe there is something similar in another example folder.

Copy link
Member

Would you be interested in turning this into a post for our blog? With a little more discussion about gradient descents and also plotting?

Copy link
Author

Would you be interested in turning this into a post for our blog? With a little more discussion about gradient descents and also plotting?

@story645 Of course, I have some more detailed examples and discussions about gradient descent in practice.

story645 and jklymak reacted with thumbs up emoji

Copy link
Member

Awesome! 🤩 Contributing guide is at https://matplotlib.org/matplotblog/posts/how-to-contribute/

Copy link
Member

jklymak commented May 14, 2021

OK, I'll close this here. Thanks @vitorglemos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
status: needs clarification Issues that need more information to resolve. status: needs revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /