-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
ENH: errorbar in qt figureoptions #18650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andyfaff
commented
Oct 4, 2020
Possibly the most controversial change is adding a generator to flatten a nested sequence, I added this to make it easier to grab all the lines out of ErrorbarCollection.lines.
QuLogic
commented
Oct 6, 2020
There is a flatten in matplotlib.cbook.
andyfaff
commented
Oct 6, 2020
I'll remove the flatten I added, and use the other one. Otherwise is the PR in a suitable form?
andyfaff
commented
Oct 10, 2020
@QuLogic refactored to use flatten from matplotlib.cbook
jklymak
commented
Apr 23, 2021
Who is our figureoption guru? I've never used it, but hopefully someone will step up and shepherd this.
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.
PR Summary
I'd like to change various properties of an errorplot using a Qt figureoptions dialogue. This dialog is presented when NavToolBar is created. At the moment
errorplots do not show up in the Curves tab, so one can't change their colour, markersize, etc.This PR detects if an ErrorbarCollection is present, and adds it to the Curves popup list. This permits adjustment of the line/marker properties of the 'host' Line. Pragmatically the bars/caps of the
errorplotare set to be the same color as the host Line, and the same linewidth of the host Line.fixes #18631
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).