Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support usetex in date Formatters #18558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklymak merged 3 commits into matplotlib:master from QuLogic:date-usetex
Oct 14, 2020
Merged

Conversation

Copy link
Member

@QuLogic QuLogic commented Sep 24, 2020
edited
Loading

PR Summary

And some small cleanup.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member Author

QuLogic commented Sep 25, 2020

So currently, this just blanket modifies the resulting string to work in TeX mode, but I wonder if it should be more nuanced and change the formatters for only the numbers?

Copy link
Member

jklymak commented Sep 30, 2020

This seems reasonable, but the tests aren't passing....

Copy link
Member Author

QuLogic commented Sep 30, 2020

Ooops, that's because I set the default to True instead of None.

@QuLogic QuLogic marked this pull request as ready for review September 30, 2020 22:58
@tacaswell tacaswell added this to the v3.4.0 milestone Oct 14, 2020
Copy link
Member

I am inclined to merge this as-is because people still have the option of specifying the format strings as they wish (and not relying on us to auto-tex-ify them) and we can down down the route of trying to parse the dateformats and decide which should be strings and which are numbers that should be texified when someone asks for it.

jklymak reacted with thumbs up emoji

@jklymak jklymak merged commit a6d684f into matplotlib:master Oct 14, 2020
@QuLogic QuLogic deleted the date-usetex branch October 14, 2020 19:12
Copy link
Member

jklymak commented Oct 14, 2020

Thanks for the nudge - I forgot about this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /