-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Deprecate hatch patterns with invalid values #17926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@QuLogic
QuLogic
force-pushed
the
warn-hatch
branch
2 times, most recently
from
July 15, 2020 05:49
9e10c6e to
9bbc045
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 👍 overall. backend_bases.GraphicsContextBase also has a set_hatch, does the same validation need applying there?
timhoffm
timhoffm
approved these changes
Jul 15, 2020
Instead of the hatch demo, which doesn't do what the docstring says it does.
@QuLogic
QuLogic
force-pushed
the
warn-hatch
branch
from
July 16, 2020 23:39
9bbc045 to
4da5274
Compare
I didn't expect a user to be calling backend_bases.GraphicsContextBase.set_hatch directly, so that's why I didn't add anything to it.
dstansby
dstansby
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I noticed while going over the hatch doc PRs that we don't really validate this. This magically works because we just check for the count of the various hatch characters. Since it used to 'work', this adds a deprecation period over which people can fix their calls.
Also, use the new hatch style reference in the
Collectiondocstring since that's more in line with what the docstring is asking for.PR Checklist