-
-
Notifications
You must be signed in to change notification settings - Fork 8k
frame_format to support all listed by animation writers #17909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...y animation writers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally add another test checking the exception for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that, but I think that correctness is implied by an already existing test for validate_stringlist.
Thanks @bmcfee!
Thanks for merging!
PR Summary
Fixes #17908 . As documented in the issue, various animation writers support different formats, and there is no way to set the format directly from the API. This forces users to go through rcParams, but rcParams only listed a subset of frame formats.
This PR extends the supported frame formats in
rcsetup.pyto support any format supported by at least one writer. If the user selects a format that is not supported by their chosen writer, an exception will be raised at runtime (rather than at configuration time). This will allow a user to, for example, usesvgformat forjshtmloutput, which is not currently possible.PR Checklist