-
-
Notifications
You must be signed in to change notification settings - Fork 8k
TST/CI: also try to run test_user_fonts_win32 on azure #16725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage on that file went down 1.67% for the xfail line, which I guess is what you want?
There are some additional coverage differences in the report. I think we might have different/non-installed versions of Ghostscript, plus maybe the setlocale in matplotlib.testing.setup should have coverage ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense...
I'll let you pick a milestone and selfmerge.
...725-on-v3.2.x Backport PR #16725 on branch v3.2.x (TST/CI: also try to run test_user_fonts_win32 on azure)
This will hopefully also help make our code coverage results less
flaky.
I think what is happening is:
pytest.xfail line
pytest.xfail and the measured code coverage goes down 🤦
Hopefully this will always skip this line on CI (as it will actually
run the tests!) which should make our coverage more stable. I suspect
it would be better to move this check into a pytest.mark, but....
PR Summary
PR Checklist