Turn mathtext.GlueSpec into a (private) namedtuple. #16683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit into matplotlib:master from anntzer:gluespec

Mar 6, 2020

Merged

Turn mathtext.GlueSpec into a (private) namedtuple. #16683

tacaswell merged 1 commit into matplotlib:master from anntzer:gluespec

Mar 6, 2020

Conversation

anntzer

Copy link

Contributor

@anntzer anntzer commented Mar 5, 2020

The old implementation was basically a hand-rolled (mutable) namedtuple.
Because actual namedtuples are immutable, Glue(..., copy=True/False) has
no effect anymore, so deprecate it too.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is Flake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added topic: text/mathtext Maintenance labels

Mar 5, 2020

@anntzer anntzer added this to the v3.3.0 milestone

Mar 5, 2020

@anntzer anntzer force-pushed the gluespec branch from 6bf58c2 to b89d5b3 Compare

March 5, 2020 17:30

@tacaswell

Copy link

Member

tacaswell commented Mar 5, 2020

👍 in principle. The test failures (only on mac?) are glyph related. Could they be real?

@anntzer


 Turn mathtext.GlueSpec into a (private) namedtuple.

1e7db60

The old implementation was basically a hand-rolled (mutable) namedtuple.
Because actual namedtuples are immutable, Glue(..., copy=True/False) has
no effect anymore, so deprecate it too.