Remove outdated comment re: PYTHONHASHSEED and pytest. #16407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anntzer merged 1 commit into matplotlib:master from anntzer:unhashseed

Feb 7, 2020

Merged

Remove outdated comment re: PYTHONHASHSEED and pytest. #16407

anntzer merged 1 commit into matplotlib:master from anntzer:unhashseed

Feb 7, 2020

Conversation

anntzer

Copy link

Contributor

@anntzer anntzer commented Feb 4, 2020

It's been unneeded since pytest 3.2 (pytest-dev/pytest@a546a61) and we now require pytest>=3.6.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is Flake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Documentation topic: testing labels

Feb 4, 2020

@anntzer anntzer added this to the v3.3.0 milestone

Feb 4, 2020

@anntzer


 Remove outdated comment re: PYTHONHASHSEED and pytest.

1a8a615

It's been unneeded since pytest 3.2 and we now require pytest>=3.6.

@anntzer anntzer force-pushed the unhashseed branch from 176648b to 1a8a615 Compare

February 4, 2020 21:10

@codecov

Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #16407 into master will decrease coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #16407 +/- ##
==========================================
- Coverage 80.85% 80.45% -0.41% 
==========================================
 Files 307 307 
 Lines 75745 74404 -1341 
 Branches 9690 9687 -3 
==========================================
- Hits 61245 59859 -1386 
- Misses 11961 11997 +36 
- Partials 2539 2548 +9

Impacted Files	Coverage Δ
lib/matplotlib/backends/backend_macosx.py	`4.54% <0.00%> (-36.12%)`	⬇️
lib/matplotlib/tests/test_font_manager.py	`85.21% <0.00%> (-6.59%)`	⬇️
lib/matplotlib/testing/jpl_units/StrConverter.py	`15.55% <0.00%> (-5.28%)`	⬇️
lib/matplotlib/testing/jpl_units/EpochConverter.py	`69.69% <0.00%> (-4.67%)`	⬇️
lib/matplotlib/tests/test_backends_interactive.py	`87.75% <0.00%> (-4.41%)`	⬇️
lib/matplotlib/docstring.py	`65.00% <0.00%> (-3.19%)`	⬇️
lib/matplotlib/backends/qt_compat.py	`48.42% <0.00%> (-3.16%)`	⬇️
...b/matplotlib/testing/jpl_units/UnitDblConverter.py	`65.85% <0.00%> (-2.33%)`	⬇️
lib/matplotlib/backend_managers.py	`20.95% <0.00%> (-2.30%)`	⬇️
lib/matplotlib/font_manager.py	`73.73% <0.00%> (-1.55%)`	⬇️
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47fc9d...1a8a615. Read the comment docs.