-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add parameter inlcude_hidden to get_*ticklabels() #16210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cd06a10 to
22078c1
Compare
...ls should be included in get*_ticklabel
22078c1 to
ef64cf8
Compare
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.
I'm not convinced anymore this is the right way forward. From a user/API perspective an include_hidden parameter feels wrong.
Hidden tick labels should be an implementation detail (or not exist at all). They should not leak out to the user.
That said, I'm not clear on the way forward for the original issue, but I'm convinced that include_hidden would only be a bandaid to cover a deeper design problem.
Closing because I'm not following up on this PR.
PR Summary
Following the discussion in #16197,
get_*ticklabels()returns only the visible ticks.In the dev call we decided to add a kwarg that optionally enables returning also hidden ticks.
Status
There are multiple nested functions here calling each other. We'd need to apply the changes to all of them.
So fatr I've just implemented the changes to
Axis. The others are essentially copy&paste, but I'd like to have this right and not apply docstring changes to all 12 methods multiple times; so please comment.Axis.get_ticklabelsAxis.get_majorticklabelsAxis.get_minorticklabels_AxesBase.get_xticklabels_AxesBase.get_xmajorticklabels_AxesBase.get_xminorticklabels_AxesBase.get_yticklabels_AxesBase.get_ymajorticklabels_AxesBase.get_yminorticklabelsAxes3D.get_ticklabelsAxes3D.get_majorticklabelsAxes3D.get_minorticklabels