Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

FIX: use supported attribute to check pillow version #16086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 1 commit into matplotlib:v3.2.x from tacaswell:fix_pil_versioncheck
Jan 4, 2020

Conversation

Copy link
Member

@tacaswell tacaswell commented Jan 4, 2020

the PILLOW_VERSION attribute was deprecated in pillow 5.2 and removed
in pillow 7.0. The version attribute is present in the minimum
version we check (3.4).

closes #16083

hugovk reacted with thumbs up emoji 
the PILLOW_VERSION attribute was deprecated in pillow 5.2 and removed
in pillow 7.0. The __version__ attribute is present in the minimum
version we check (3.4).
closes matplotlib#16083
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 4, 2020
@tacaswell tacaswell added this to the v3.2.0 milestone Jan 4, 2020
Copy link
Member Author

This will have to be backported to v3.1.x and v2.2.x

@timhoffm timhoffm merged commit 9bb8e6c into matplotlib:v3.2.x Jan 4, 2020
Copy link
Member

timhoffm commented Jan 4, 2020

@meeseeksdev backport to v3.1.x

Copy link
Member

timhoffm commented Jan 4, 2020

v2.2.x does not have the version check and thus does not need a backport.

timhoffm added a commit that referenced this pull request Jan 4, 2020 
...086-on-v3.1.x
Backport PR #16086 on branch v3.1.x (FIX: use supported attribute to check pillow version)
@tacaswell tacaswell deleted the fix_pil_versioncheck branch January 6, 2020 13:51
Copy link
Member Author

Thanks for taking care of the backports @timhoffm !
timhoffm and hugovk reacted with thumbs up emoji

Copy link
Contributor

hugovk commented Jan 17, 2020

Is there a rough schedule for the next release (eg. 3.1.x or 3.2.0) with this fix? Thanks!

Copy link
Member Author

I am working on it right now, goal is 2.2.5, 3.1.3, and 3.2.0rc3 by end of day tomorrow 🤞 .
hugovk reacted with thumbs up emoji

Copy link
Member Author

Ended up going down a few extra rabbits holes (and having to fix a pandas related bug) and took almost 2 more weeks, but I just tagged 3.1.3, should make it's way out through the binary channels in the next few days.

Sorry this took so long.
hugovk reacted with thumbs up emoji hugovk reacted with hooray emoji hugovk reacted with rocket emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

+1 more reviewer

@hugovk hugovk hugovk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /