Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix v_interval setter #16053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kojoley merged 1 commit into matplotlib:master from timhoffm:fix-v_interval_setter
Jan 7, 2020
Merged

Conversation

Copy link
Member

@timhoffm timhoffm commented Dec 31, 2019 •
edited
Loading

PR Summary

Regression from #14579. As a result setting properties Axis.v_interval and Axis.d_interval did not work.

Comments suggest testing or deprecating. But I don't want to spend more time on this:

  • Re testing: More tests are always nice, but here it's obvious that the fix just fixes a copy-paste bug.
  • Re deprecating: Might make sense. However, additional properties are not that much of an API problem. They just came in via Fix inversion of 3d axis. #14579 when these attibutes were turned into properties.

Therefore I'd like to push this PR as minimal as it is. If anybody want to take further action, feel free.

@timhoffm timhoffm added this to the v3.1.3 milestone Dec 31, 2019
@Kojoley Kojoley merged commit 3218b11 into matplotlib:master Jan 7, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
@timhoffm timhoffm deleted the fix-v_interval_setter branch January 7, 2020 21:25
timhoffm added a commit that referenced this pull request Jan 7, 2020 
...053-on-v3.2.x
Backport PR #16053 on branch v3.2.x (Fix v_interval setter)
timhoffm added a commit that referenced this pull request Jan 7, 2020 
...053-on-v3.1.x
Backport PR #16053 on branch v3.1.x (Fix v_interval setter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /