-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix search on nested pages #16007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix search on nested pages #16007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@timhoffm
timhoffm
added
Documentation
Release critical
For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
labels
Dec 22, 2019
jklymak
jklymak
approved these changes
Dec 22, 2019
dstansby
dstansby
approved these changes
Dec 23, 2019
@meeseeksdev backport to v3.2.x
Is meeseeksdev broken?
For the milestone at least, it was missing the relevant magic text to trigger backporting.
@meeseeksdev backport to v3.1.x
@meeseeksdev backport to v3.2.x
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 25, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 25, 2019
QuLogic
added a commit
that referenced
this pull request
Dec 25, 2019
...007-on-v3.2.x Backport PR #16007 on branch v3.2.x (Fix search on nested pages)
QuLogic
added a commit
that referenced
this pull request
Dec 25, 2019
...007-on-v3.1.x Backport PR #16007 on branch v3.1.x (Fix search on nested pages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes a regression from #15859. Search got a 404 error on pages that were not on the same directory level as
search.html(e.g. https://matplotlib.org/devdocs/api/_as_gen/matplotlib.gridspec.GridSpec.html).Hard-coding
search.htmlwas a copy-paste error. This fix uses the same solution as the original sphinx search box (https://github.com/sphinx-doc/sphinx/blob/d82e7c12a177a6a547ba1e72540f079f64590f8a/sphinx/themes/basic/searchbox.html#L14).