-
-
Notifications
You must be signed in to change notification settings - Fork 8k
TST: verify warnings fail the test suite #15169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That doesn't seem to be working :p
I think it is working, the @pytest.xfail passes even if the wrapped test fails, and the stirict=True flag makes @pytest.xfail fail if the wrapped tests passes.
The reason that the pre-release is currently passing is that while we were installing the beta, we were actually testing with the system python (which was py36), #15168 has a fix for that, but it is failing during installation of dependencies now.
Ok, I finally understood it. On the other hand, I'm confused on why we are testing this in our test suite. It doesn't have much to do with Matplotlib.
We set pytest to fail on warnings in our test setup:
I'm not convinced it's useful, but ok. 👍
PR Summary
I expected the tests on azure on preview python to be failing without #15168 so adding a test the will fail if it does not fail on warnings 🤕
The other explanation for it passing is I am confused about if b4 should have the upstream changes that are causing the warnings.
PR Checklist