Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Register 3d projection by default. #13520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 1 commit into matplotlib:master from anntzer:register3d
Feb 27, 2019
Merged

Conversation

Copy link
Contributor

@anntzer anntzer commented Feb 26, 2019

Now that we always install mpl_toolkits (#12317), we may as well always register
mplot3d and save an "apparently unused" import for the users (#12249).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

twmr and folkol reacted with thumbs up emoji
@@ -70,3 +73,7 @@ def get_projection_names():
Get a list of acceptable projection names.
"""
return projection_registry.get_projection_names()


# Register Axes3D.
Copy link
Member

@tacaswell tacaswell Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need this any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, indeed, fixed

 

Now that we always install mpl_toolkits, we may as well always register
mplot3d and save an "apparently unused" import for the users.
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests and docs work.

Copy link
Contributor Author

anntzer commented Feb 27, 2019

they passed

@timhoffm timhoffm merged commit cd0de0b into matplotlib:master Feb 27, 2019
Copy link
Member

Worth a backport to 3.1.x?
timhoffm reacted with thumbs up emoji tacaswell reacted with thumbs down emoji

@anntzer anntzer deleted the register3d branch February 27, 2019 16:46
Copy link
Member

People are often concerned about the load/import time of matplotlib (#2188, #11546, ). Are the implications clear on this?

Copy link
Contributor Author

anntzer commented Feb 28, 2019

Examining the output of python -X importtime -c 'import matplotlib.pyplot, mpl_toolkits.mplot3d' indicates that the slowdown should be on the order of 1% (~3ms vs 300ms).
ImportanceOfBeingErnest reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /