Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

FIX: polar set_rlim allow bottom-only call #13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstansby merged 2 commits into matplotlib:master from jklymak:fix-polar-bottom
Feb 23, 2019

Conversation

Copy link
Member

@jklymak jklymak commented Feb 18, 2019 •
edited
Loading

PR Summary

closes #13464

Not sure this is the canonical way to do this. Improvements welcome.

(削除) Should obviously get a test so this doesn't get missed again. (削除ここまで)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak changed the title (削除) FIX: allow bottom-only call (削除ここまで) (追記) FIX: pooler set_rlim allow bottom-only call (追記ここまで) Feb 19, 2019
@jklymak jklymak changed the title (削除) FIX: pooler set_rlim allow bottom-only call (削除ここまで) (追記) FIX: polar set_rlim allow bottom-only call (追記ここまで) Feb 19, 2019
@jklymak jklymak added topic: polar Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Feb 19, 2019
@jklymak jklymak added this to the v3.1.0 milestone Feb 19, 2019
if top is None and len(bottom) == 2:
top = bottom[1]
bottom = bottom[0]
if top is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_xlim uses

 if right is None and np.iterable(left):
 left, right = left

I think it's reasonable to use the same pattern here.

Note: This will explicitly fail set_rlim((1, 2, 3)). Your code would let that pass, and I assume it would have failed later on, since the assumption from here on is that bottom is a scalar.

anntzer reacted with thumbs up emoji
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member Author

jklymak commented Feb 22, 2019

@QuLogic I think you recently did heavy polar work. Is this fix OK?

Copy link

lumberbot-app bot commented Feb 23, 2019

Something went wrong ... Please have a look at my logs.

timhoffm added a commit that referenced this pull request Feb 23, 2019 
...465-on-v3.1.x
Backport PR #13465 on branch v3.1.x (FIX: polar set_rlim allow bottom-only call)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

@QuLogic QuLogic Awaiting requested review from QuLogic

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

set_rlim(bottom=...) no longer works

AltStyle によって変換されたページ (->オリジナル) /