-
-
Notifications
You must be signed in to change notification settings - Fork 8k
cairo: remove the append_path() fast path #13042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the performance improvements in matplotlib#13039 the old slow path is now faster than the previously fast one. And it also works with pycairo. Using the Gtk3Cairo backend with wire3d_animation_sgskip.py: cairocffi + append_fast: 13.27 fps cairo + append_slow: 15.07 fps cairocffi + append_slow: 13.54 fps
@lazka
lazka
force-pushed
the
cairo-remove-fast-path
branch
from
December 25, 2018 10:01
bc6bd9b to
d6ce849
Compare
This should be ready now.
timhoffm
timhoffm
approved these changes
Dec 25, 2018
tacaswell
tacaswell
approved these changes
Dec 25, 2018
I would like @anntzer to take a look at this before we merge, I suspect this orthogonal to mplcairo, but just want to be sure.
I was thinking that for very long paths (e.g. plot(np.random.rand(10000))), the "fast" codepath would still be preferable (as it converts the whole Path object to cairo's internal representation in one go, rather than looping on Python's side), but interestingly this is not the case.
I thought what's happening is that:
- for short paths, @lazka's optimizations made python-side iteration fast enough that the previously slow path is good enough,
- for long paths, when rasterizing to the screen or to png, it's the rasterization time itself that starts dominating over the loop-in-python (because the rasterizer must check for all possible self-intersections of the path).
However, the "slow" codepath is actually also faster when writing to a vector format (e.g. pdf), so that can't be the only explanation involved.
In any case, I can repro the reasonable performance (and yes this is totally orthogonal to mplcairo, thanks for the heads up).
anntzer
anntzer
approved these changes
Dec 29, 2018
Thanks! :)
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Dec 31, 2018
As seen in matplotlib#13042 it's a bit faster than cairocffi and it also takes 50 ms less time to import here. Also the GTK3Cairo backend requires pycairo, so there is a good chance it's already loaded anyway for that case.
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Dec 31, 2018
As seen in matplotlib#13042 it's a bit faster than cairocffi and it also takes 50 ms less time to import here. Also the GTK3Cairo backend requires pycairo, so there is a good chance it's already loaded anyway for that case.
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Dec 31, 2018
As seen in matplotlib#13042 it's a bit faster than cairocffi and it also takes 50 ms less time to import here. Also the GTK3Cairo backend requires pycairo, so there is a good chance it's already loaded anyway for that case.
6 tasks
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Dec 31, 2018
As seen in matplotlib#13042 it's a bit faster than cairocffi and it also takes 50 ms less time to import here. Also the GTK3Cairo backend requires pycairo, so there is a good chance it's already loaded anyway for that case.
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Jan 6, 2019
As seen in matplotlib#13042 it's a bit faster than cairocffi and it also takes 50 ms less time to import here. Also the GTK3Cairo backend requires pycairo, so there is a good chance it's already loaded anyway for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
With the performance improvements in #13039 the old slow path is now faster
than the previously fast one. And it also works with pycairo.
Using the Gtk3Cairo backend with wire3d_animation_sgskip.py:
cairocffi + append_fast: 13.27 fps
cairo + append_slow: 15.07 fps
cairocffi + append_slow: 13.54 fps
PR Checklist