-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Include template matplotlibrc in package_data. #11273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WeatherGod
merged 1 commit into
matplotlib:master
from
anntzer:matplotlibrctemplate-in-package-data
May 20, 2018
Merged
Include template matplotlibrc in package_data. #11273
WeatherGod
merged 1 commit into
matplotlib:master
from
anntzer:matplotlibrctemplate-in-package-data
May 20, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make the tests pass for a non-editable install.
Is this file going to be auto-generated before it gets included? I am not exactly sure how this process works in setuptools.
tacaswell
tacaswell
approved these changes
May 19, 2018
@WeatherGod It's always present in the source tree.
What do you mean? It isn't in the source tree.
https://github.com/matplotlib/matplotlib/tree/master/lib/matplotlib/mpl-data
... On Sat, May 19, 2018 at 4:30 PM, Antony Lee ***@***.***> wrote:
@WeatherGod <https://github.com/WeatherGod> It's always present in the
source tree.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11273 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-Cla722p0Z4QgGrsW15aVXg-PqTgks5t0IDvgaJpZM4UFIV3>
.
Oh sorry, my bad.
But yes, it is generated by setup.py
with open('lib/matplotlib/mpl-data/matplotlibrc', 'w') as fd:
fd.write(
template.safe_substitute(TEMPLATE_BACKEND=default_backend))
and that happens even before setuptools has a chance to look at sys.argv, IOW early enough in the process for things to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to make the tests pass for a non-editable install.
Should close #10717 (attn @matthew-brett).
PR Summary
PR Checklist