-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Re-run boilerplate.py. #11251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Re-run boilerplate.py. #11251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove second blank line between cmap definitions, consistently with the other wrapper functions.
QuLogic
QuLogic
approved these changes
May 15, 2018
Merging to fix build issues.
Just a remark:
Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.
Technically, PEP-8 wants two blank lines between top-level functions. Not sure why it does not complain. Maybe we have deactivated that check, or the comment counts as blank line. Didn't check.
- It's probably disabled for that specific file
- PEP8 also says "Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations)." Yes, these are strictly speaking not one-liners, but I think it's close in spirit (and think 2 blank lines are totally pointless here).
Thank you @anntzer !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.
xref #11234 (comment)
Planning to selfmerge as "unbreaking the build".
PR Summary
PR Checklist