-
Notifications
You must be signed in to change notification settings - Fork 51
ENH: add helpers to merge extra data into a cycler instance #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #47 +/- ## ========================================== - Coverage 100% 98.41% -1.59% ========================================== Files 1 1 Lines 184 189 +5 Branches 51 53 +2 ========================================== + Hits 184 186 +2 - Misses 0 3 +3
Continue to review full report at Codecov.
|
From private discussions with @WeatherGod
68e832a to
5f00bec
Compare
tacaswell
commented
Sep 13, 2019
@WeatherGod took 18 months, but I addressed your comments!
@WeatherGod
WeatherGod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also have unit test, which could just be duplicated for the docstring example I mentioned, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be pedantic, wouldn't the first Any be Hashable? I haven't gotten fully into the annotation habit yet, so I don't know if Mapping already implies Hashable for the keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name here doesn't match the name in the call signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docstring would greatly benefit from an example. As it stands right now, I have to think really hard to understand the use-cases for this function (and I am the one who originally thought of this idea!).
timhoffm
commented
Sep 14, 2019
Is there a reason these are stand alone functions? I would have expected
- a class method
Cycler.from_dicts - an instance method
Cycler.merge_supplemental
tacaswell
commented
Sep 18, 2019
@timhoffm Fair, but I think that one level of nesting cycler.Cycler.from_dicts and neither function needs access to the class object.
Still not sure this is a good idea. Maybe this should just go into the docs as an example?
From private discussions with @WeatherGod
This still needs: