-
Notifications
You must be signed in to change notification settings - Fork 51
Enh tail #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Enh tail #39
+127
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also start using codecov
Add a generator function to add an infinite 'tail' onto a cycler. Closes matplotlib#30
Contributor
danielballan
commented
Jul 8, 2016
I lean toward preferring this as a documented example.
Member
WeatherGod
commented
Jul 8, 2016
ditto. Plus, I am not so keen on the idea of having to specify a dictionary to be the tail. If you have the dictionary, then why not just chain the cycler and a cycle of that dictionary together? If I want my cycler to have a long tail, then I would likely want its last element to be the tail item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only look at the second commit.
This is mostly for discussion. As with #38 this is a useful function, but not sure it is useful enough / has a 'correct' enough API to be worth shipping with the package and they can instead (continue to) live as examples in the documentation (as with https://docs.python.org/3.5/library/itertools.html#itertools-recipes)