-
Notifications
You must be signed in to change notification settings - Fork 38
Made it so products can have their amounts varied at runtime - #2
Open
leoamaro01 wants to merge 3 commits into
Open
Made it so products can have their amounts varied at runtime #2leoamaro01 wants to merge 3 commits into
leoamaro01 wants to merge 3 commits into
Conversation
Changed Units property's "set" accessor back to private. Added AddUnits(int) method for this purpose. Reformatted Add method in Cart to reflect this change.
leoamaro01
commented
Apr 26, 2022
Author
There is a problem with these changes, the catalog product objects are the same as those in the cart, not copies, so when the Units property of a Product object is changed in the cart, the change is reflected in the catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.