Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: call onPointSelected only when gesture is active#123

Open
gustavomts wants to merge 1 commit into
margelo:main from
gustavomts:fix_on_point_selected_callback
Open

fix: call onPointSelected only when gesture is active #123
gustavomts wants to merge 1 commit into
margelo:main from
gustavomts:fix_on_point_selected_callback

Conversation

@gustavomts

@gustavomts gustavomts commented Sep 18, 2025
edited
Loading

Copy link
Copy Markdown

There's an issue happening when you change points after having activated the gesture once. The onPointSelected callback is executed even though there's no gesture active at the moment. You can see the problem in the video below. You'll notice that the current price changes to a "random" value that's actually what's being passed to onPointSelected when the points prop change.

ScreenRecording_09-18-2025.10-37-44.AM_1.mov

After the fix, the behavior is what I believe to be expected: the onPointSelected callback is not called after changing the points.

ScreenRecording_09-18-2025.10-45-06.AM_1.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /