-
Notifications
You must be signed in to change notification settings - Fork 78
fix(conversations): let g/G be typed into the session search box#263
Open
youdie006 wants to merge 1 commit into
Open
fix(conversations): let g/G be typed into the session search box #263youdie006 wants to merge 1 commit into
youdie006 wants to merge 1 commit into
Conversation
The session-filter search input bound g/G to goto-top/bottom list navigation, so they were swallowed before reaching the query (typing "go" yielded "o"). Drop those bindings so g/G fall through to the default typing branch, mirroring the arrow-key-only navigation precedent already applied to up/down/h here. Closes marcus#166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typing
gorGin the conversations search box was swallowed (typing "go" produced "o", #166): the session-filter search input boundg/Gto the vim goto-top/bottom list navigation, so they fired before reaching the query.Fix
internal/plugins/conversations/plugin_input.go: drop theg/Gcases fromupdateSearchso both fall through to the default typing branch, mirroring the arrow-key-only navigation precedent already applied to up/down/h in this input. Added a test that types "go"/"G" in search mode and asserts they land in the query.Closes #166