-
Notifications
You must be signed in to change notification settings - Fork 170
Added route dependency injection for anonymous controllers#132
Open
stargazer-2697 wants to merge 2 commits into
Open
Added route dependency injection for anonymous controllers #132stargazer-2697 wants to merge 2 commits into
stargazer-2697 wants to merge 2 commits into
Conversation
marcoslin
commented
Mar 17, 2015
Owner
Hi,
Thanks for the pull request. Any reason to change the order of param in the test instead of changing the order of param in the angularAMD?
Sorry if I missed something obvious but day job is sucking every second of my life away at the moment.
stargazer-2697
commented
Mar 19, 2015
Author
It's for simplicity really. The PR appends any local dependencies from config.resolve to the $inject property of the proxy controller. Since $scope is also a local dependency, I reordered the params so all the local dependencies will be adjacent. This way, I can simply iterate over arguments[2..n] instead of arguments[0] and then arguments[3..n].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lost dependencies when routing with an anonymous controller. See discussion.