-
Notifications
You must be signed in to change notification settings - Fork 513
"#53 the gradle version was updated to the latest, as well the java v... #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...he java version"
stianrincon
commented
Feb 20, 2019
Hi, I am just curious about this pull request, so I want to know if you have had the opportunity of checking it.
sjaakd
commented
Feb 22, 2019
@stianrincon .. sorry.. I'm not an expert on gradle.. Perhaps @filiphr can have a look at this..
Thanks anyway..
@filiphr
filiphr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @stianrincon. This looks OK to me. However, I think that we should not up the source compatibility to 11. Was there a reason for this?
Apart from that I see that that a .DS_Store file was committed as well. Can you please remove that from your commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should this be 11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys, thanks for replying, I will remove .DS_Store file. And about sourceCompatibility = 11 it was as a way to have the example with the latest java. But if it was not good I can keep it as sourceCompatibility = JavaVersion.VERSION_1_8. So @filiphr you please just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep 1.8. We can add a comment that people can put 11 and it would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for these changes and getting this PR merged!
sjaakd
commented
Oct 5, 2019
I just merged in another PR which goal was more or less the same.
@stianrincon can you rebase your PR and see if all is correct in the master currently? If so, I guess we can close this one. Thanks for contributing.
Hi, I was updating the Gradle version to the latest. Based on the fact that wrapper task is not needed I removed the script about wrapper but I take care of updating the gradlew and the other files so we can run the command "./gradlew clean build", finally I was updating the example for using java 11.