-
Notifications
You must be signed in to change notification settings - Fork 80
fix: remove parse due unsafety and replace it with parseRows#75
Open
matheusfcorocher wants to merge 2 commits intomapbox:gh-pages from
Open
fix: remove parse due unsafety and replace it with parseRows #75matheusfcorocher wants to merge 2 commits intomapbox:gh-pages from
matheusfcorocher wants to merge 2 commits intomapbox:gh-pages from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Fix unsafety detected by issue #73
What changed, and why?
parsefunction and replace byparseRowsfrom csv2geojson.In d3-dsv repository says that parse is unsafety and you can replace for parseRows.
Go to Content Security Policy in this link: https://github.com/d3/d3-dsv
How is this tested?
All the tests passed. No further tests were required for this fix.