-
Notifications
You must be signed in to change notification settings - Fork 182
Small improvements #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@debnet
debnet
commented
Jan 4, 2016
- Fixing displayed URL by using pattern instead of name_parent regex (for namespaced URLs mainly)
- Distinction between custom API views and RESTFul APIs generated through models and routers
- Adding possibility to use app_name in URL patterns for API organisation
- Adding an URL to filter APIs by app_name or name_parent
Added the possibility to filter by application name in the url + modifed the name_parent's value of the ApiEndpoint
Tests added for the new features
A few small bits:
- When in
/docs/app_name/can we hide the "Jump to" dropdown from the navbar? - Link each app name(heading) to that url? (Maybe on hover show an
#that links to that url - or something similar) - What if there is no defined
app_namefor a namespace? Would be great if we can use something like theparentso that it works with all the namespaces.
Other than that it looks great! Can't wait to merge it ✨
OK, we are working on it. ;)
- Add link to the ''/docs/[filter_name]'' for each group.grouper (name_parent) - Parameter in the 'docs/filter_name' now works with app_name or namespace - WARNING: Modify the urlpatterns for django version >= 1.9 (see deprecated use of app_name : https://docs.djangoproject.com/en/1.9/ref/urls/#include)
Done. Just to do some styling on title hyperlinks, we leave it to you. ;)
Exemple:
h1 { > a { color:#2C3E50 ; &:hover { text-decoration: none; } } }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.