Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support Django 2.0 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasperlittle wants to merge 11 commits into manosim:master
base: master
Choose a base branch
Loading
from jasperlittle:master
Open

Support Django 2.0 #177

jasperlittle wants to merge 11 commits into manosim:master from jasperlittle:master

Conversation

Copy link

@jasperlittle jasperlittle commented Feb 3, 2018

This pull request aims to provide support for all supported versions of Django and Djano REST Framework.(affecting #175). The support now offered is summarised in the table below:

DRF 3.4 DRF 3.5 DRF 3.6 DRF 3.7
Django 1.10 x x x x
Django 1.11 x x x x
Django 2.0 python 3.4+

where 'x' indicates support for python 2.7, 3.4, 3.5 and 3.6.

Support has dropped for Django 1.8 and 1.9, as well as python 3.2 and 3.3. I believe this is for the best, as Django 1.9 and below are considered insecure, and python 3.2 and 3.3 are not supported from Django
1.9 onwards.

Compatibility between Django 1.x and 2.x is achieved by adding a compatibility layer, in a similar manner to that of Django REST Framework

Testing for the various supported configurations is done using tox.

iesteban, psyonara, yizhang7210, rodolfolottin, Beomi, Leeaandrob, cwirz, JasperSui, and Bhupesh-V reacted with hooray emoji
Copy link
Author

Oops, I wasn't familiar with the Travis CI process. Final 2 commits should have fixed that

Copy link

I tested it, works fine! Thank you for this contribution. Hope that it will be merged soon.

Copy link

Thank you, @jasperlittle!

Copy link

Thank you @jasperlittle!!!

Copy link

Technically, Django 1.8 still has extended support, but this is only until 1 April. And besides we have a much newer LTS in Django 1.11, so dropping 1.8 is a good decision IMO.

Copy link

Is there any prevision for merge?

Copy link

Also watching this. Really hope this great lib can carry on!

Copy link

Hope this get to be a part of a release.

Copy link

Thanks @jasperlittle

Copy link

TheBlackDude commented Apr 4, 2018 •
edited
Loading

Any ideas when this PR is going to be merged @manosim ???

Copy link
Owner

manosim commented Apr 4, 2018

Hello there! Have given push access to @jasperlittle so he can merge and release 😄
whitedogg13, giovannicimolin, jakuub, cwirz, and iamhssingh reacted with thumbs up emoji psyonara, cwirz, and BGBRWR reacted with hooray emoji

Copy link

cwirz commented Apr 16, 2018

Have tested it and get some regex problems in the template so that the user is not able to test the api there:

screen shot 2018年04月16日 at 20 36 26
screen shot 2018年04月16日 at 20 36 31

Copy link

Does anyone have the status about this pull request? I see that some regex problems appeared, but is anyone working on a fix?

Copy link

Hi guys, I just created a new lib supporting Django 1.x and 2.x: django-rest-framework-redocs.

It's also a zero configuration automatic API doc page generator, please take a look and help me make it better!

Copy link

Is this still a thing?

Copy link

I believe so, but I'm not sure if someone is working on a fix for the reg-ex problem. I am a newbie myself, so I'm not sure if I can really help.

Copy link

Will love to contribute @jasperlittle @manosim

Keep this alive. been using this for a long time!

Copy link

merge?

Copy link

Is there anything else that needs to be done for this to be merged?

Copy link

@jasperlittle @manosim Hi, friends, can you give the merge access to me? I don't why there still not merge the branch.

Copy link

Waiting for this merge as well.
I really need a working, interactive API that supports tokens, as browsable API does not.

Copy link

+1 on this 😬

Copy link

mago960806 commented Aug 1, 2018 •
edited
Loading

@cwirz I just fixed it.
filename: rest_framework_docs\api_endpoint.py
line26: self.name_parent = simplify_regex(parent_regex).strip('/').replace('\','') if parent_regex else None
line42: return "/{0}{1}".format(self.name_parent, simplify_regex(regex).replace('\',''))
image
image

Copy link

Any ETA on merging and releasing this ?

Copy link

@jasperlittle @manosim updates?
iamhssingh reacted with thumbs up emoji

Copy link

How I can use it? Should I install from source?

Copy link

efazati commented Nov 17, 2018

👍

1 similar comment
Copy link

👍

Copy link

@jasperlittle Can you push and merge? You have the access.

@manosim What about pypi? Can @jasperlittle also update on pypi?

Django==1.8.7
djangorestframework==3.3.2
coverage==4.0.3
Django==1.11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause 1.11.0 to be installed, not any 1.11.*

Copy link

calina-c commented Jul 4, 2019

updates on this?

Copy link

@newsuk any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@merwok merwok merwok left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /