-
Notifications
You must be signed in to change notification settings - Fork 19
Year 2022 Day 20 regression #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This current algorithm is failing my puzzle input (a regression from your previous algorithm)
Thanks for the bug finding!
Does this change fix the issue? I'm not sure how it would produce a different result.
No, sorry for the confusion. Factoring out the multiplication just saves an instruction is all. If you navigate to my AOC repo you can test my puzzle input across your previous tree algorithm which produces the correct answer.
... On Jan 14, 2025, at 10:27 AM, maneatingape ***@***.***> wrote:
Thanks for the bug finding!
Does this change fix the issue? I'm not sure how it would produce a different result.
—
Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOMDBHW3W5L73XZG6MYJLT2KVCIRAVCNFSM6AAAAABVFK6UDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJQGYZTQMJWHA>.
You are receiving this because you authored the thread.
Please verify against your input.
Verified fixed on my input.
... On Jan 14, 2025, at 12:07 PM, maneatingape ***@***.***> wrote:
Fixed <076ea1a>.
Please verify against your input.
—
Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOMDBFSB3VOEP2WW3R4IIL2KVN7ZAVCNFSM6AAAAABVFK6UDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJQHA4TSNZSGQ>.
You are receiving this because you authored the thread.
@maneatingape
maneatingape
changed the title
(削除) Factor out a multiplication (削除ここまで)
(追記) Year 2022 Day 20 regression (追記ここまで)
Jan 14, 2025
Thanks for flagging the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.