Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Year 2022 Day 20 regression #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfarnham wants to merge 1 commit into maneatingape:main from dfarnham:dfarnham-patch-1
Closed

Year 2022 Day 20 regression #6

dfarnham wants to merge 1 commit into maneatingape:main from dfarnham:dfarnham-patch-1

Conversation

Copy link
Contributor

@dfarnham dfarnham commented Jan 14, 2025

No description provided.

Copy link
Contributor Author

This current algorithm is failing my puzzle input (a regression from your previous algorithm)

Copy link
Owner

Thanks for the bug finding!

Does this change fix the issue? I'm not sure how it would produce a different result.

Copy link
Contributor Author

dfarnham commented Jan 14, 2025 via email

No, sorry for the confusion. Factoring out the multiplication just saves an instruction is all. If you navigate to my AOC repo you can test my puzzle input across your previous tree algorithm which produces the correct answer.
...
On Jan 14, 2025, at 10:27 AM, maneatingape ***@***.***> wrote: Thanks for the bug finding! Does this change fix the issue? I'm not sure how it would produce a different result. — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOMDBHW3W5L73XZG6MYJLT2KVCIRAVCNFSM6AAAAABVFK6UDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJQGYZTQMJWHA>. You are receiving this because you authored the thread.

Copy link
Owner

Fixed.

Please verify against your input.

Copy link
Contributor Author

dfarnham commented Jan 14, 2025 via email

Verified fixed on my input.
...
On Jan 14, 2025, at 12:07 PM, maneatingape ***@***.***> wrote: Fixed <076ea1a>. Please verify against your input. — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOMDBFSB3VOEP2WW3R4IIL2KVN7ZAVCNFSM6AAAAABVFK6UDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJQHA4TSNZSGQ>. You are receiving this because you authored the thread.
maneatingape reacted with hooray emoji

@maneatingape maneatingape changed the title (削除) Factor out a multiplication (削除ここまで) (追記) Year 2022 Day 20 regression (追記ここまで) Jan 14, 2025
Copy link
Owner

Thanks for flagging the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /