Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

2017 primality test performance improvement #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@Rolv-Apneseth Rolv-Apneseth commented Jul 8, 2025

First of all, thank you so much for this repository. I learn a lot by working through problems and coming to your solutions when I'm stuck (which I must admit is often with AOC). This has been a gold mine for me.

While having a look at 2017 day 23 I noticed that the primality test could use some minor improvements to the performance, being only checking odd numbers (and 2), and using multiplication instead of finding the square root directly (though I'm not certain if the speed increase for that one is specific to my machine/architecture).

For me, these changes bring the benchmark results for part 2 from ~61μs down to ~25μs.

@maneatingape maneatingape merged commit ece0ac3 into maneatingape:main Jul 8, 2025
2 of 3 checks passed
Copy link
Owner

maneatingape commented Jul 8, 2025
edited
Loading

Neat, thanks for the speed up! (54 μs => 19 μs)

You could go even further with wheel factorization but it's probably overkill!

Rolv-Apneseth reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /