-
Notifications
You must be signed in to change notification settings - Fork 16
Use 0: for named-fields debug of tuples and tuple variants#32
Open
ijackson wants to merge 4 commits intomagiclen:master from
Open
Use 0: for named-fields debug of tuples and tuple variants #32ijackson wants to merge 4 commits intomagiclen:master from
0: for named-fields debug of tuples and tuple variants #32ijackson wants to merge 4 commits intomagiclen:master from
Conversation
We'll use this shortly.
field_name is the real field name and doesn't depend on the attribute. Separating this makes things less confusing.
Change the output when the user requests debug printing of a tuple struct in named fields syntax. Previously we output `_0: ` (for example), which isn't really right: Rust permits `0: `, and the field is actually called `0`. This is a behavioural change, but I don't think Debug output is regarded as semver-relevant, so this shouldn't be a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the output when the user requests debug printing of a tuple struct in named fields syntax.
Previously we output
_0:(for example), which isn't really right: Rust permits0:, and the field is actually called0.This is a behavioural change, but I don't think Debug output is regarded as semver-relevant, so this shouldn't be a considered breaking change.