-
Notifications
You must be signed in to change notification settings - Fork 165
Make fixer available via FileProxy #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use magic methods _get()/_set() in order to fix the issue for all public properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is being removed in #452 (which I expect to be merged in this week), making further changes to this file seems like unnecessary work.
This change is the minimum required to make the tests pass. If you would like to add additional tests and write the necessary code to make them pass, please open a new pull request with those changes.
My recommendation would be to get this merged, then #453, then #452.
Uh oh!
There was an error while loading. Please reload this page.
If #452 gets merged before this pull request, this pull request can be safely closed as the problem files are being removed there.
This pull request has been created purely so that we can progress with #453, which is blocking #452. This is not intended to be a long-term fix.
This fixes #454