-
Notifications
You must be signed in to change notification settings - Fork 165
Allow more version numbers in @deprecated tag
#439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@m2-community-project
m2-community-project
bot
added
the
Progress: ready for review
label
Mar 7, 2023
6 tasks
ihor-sviziev
ihor-sviziev
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please cover your change with automated test?
@m2-community-project
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
Apr 3, 2023
ihor-sviziev
ihor-sviziev
previously approved these changes
Apr 4, 2023
@m2-community-project
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
Apr 4, 2023
@fredden
fredden
force-pushed
the
deprecated-version-range
branch
2 times, most recently
from
September 26, 2023 16:14
6b3b7a5 to
6f6f7e0
Compare
@fredden
fredden
force-pushed
the
deprecated-version-range
branch
from
September 27, 2023 15:51
6f6f7e0 to
f232754
Compare
@fredden
fredden
force-pushed
the
deprecated-version-range
branch
from
December 8, 2023 16:43
f232754 to
b3a95b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the Static Test failures in magento/magento2#36976 (which are out of scope for the intended change), I noticed that the message required for a
@deprecatedtag does not support the version numbers that Adobe use for Magento modules. For example, themagento/module-backendmodule is currently version102.0.6, but the regular expression in the coding standard does not allow version numbers with more than one digit per part. This pull request fixes this oversight.