Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Simplify installation instructions #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredden wants to merge 1 commit into magento:develop
base: develop
Choose a base branch
Loading
from fredden:simplify-install-instructions

Conversation

Copy link
Member

@fredden fredden commented Feb 1, 2023 •
edited
Loading

The installation instructions for this coding standard are unnecessarily complex. Composer plugins are capable of performing the necessary registration automatically, without requiring the user to manually set up (or alter) any scripts sections in composer.json. The main Magento repository uses dealerdirect/phpcodesniffer-composer-installer to register the coding standard; let's use the same here.

See https://github.com/magento/magento2/blob/11846a1a10539470f2fe1522030ff42d62daa562/composer.json#L110 / magento/magento2#36791

Fixes #390

hostep, sreichel, ihor-sviziev, twosg, and iaugusto-ironplane reacted with thumbs up emoji
Copy link

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fredden Thanks for your update.
Please review my comment

Den4ik
Den4ik previously approved these changes Feb 6, 2023
Copy link

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good for me

Den4ik
Den4ik previously approved these changes Apr 12, 2023
@fredden fredden dismissed stale reviews from Den4ik and ihor-sviziev via c534321 April 28, 2023 12:45
Copy link
Contributor

@magento import PR to magento-commerce/magento-coding-standard repository

Copy link
Contributor

@sinhaparul the Pull Request is successfully imported.

@fredden fredden force-pushed the simplify-install-instructions branch 2 times, most recently from 6d8a941 to afe826d Compare September 20, 2023 15:11
@fredden fredden force-pushed the simplify-install-instructions branch from c11b4c6 to 76037c6 Compare June 9, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

+1 more reviewer

@Den4ik Den4ik Den4ik approved these changes

Reviewers whose approvals may not affect merge requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPStorm unable to run phpcs inspection

AltStyle によって変換されたページ (->オリジナル) /