-
Notifications
You must be signed in to change notification settings - Fork 165
Upgrade PSR2 -> PSR12 for ControlStructureSpacing #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sidolov what needs to happen to get this merged in? Is there anything I can do to help with that?
@magento import PR to magento-commerce/magento-coding-standard repository
@sinhaparul the Pull Request is successfully imported.
So, what is blocking this PR?
Since PSR2.ControlStructures.ControlStructureSpacing.SpacingAfterOpenBrace conflicts with PSR12.ControlStructures.ControlStructureSpacing.FirstExpressionLine and PSR2 has been
Deprecated - As of 2019年08月10日 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative.
https://www.php-fig.org/psr/psr-2/
I'd love to advance it before 2024. 🤓
@sinhaparul @sidolov, is there any reason not to merge this?
Uh oh!
There was an error while loading. Please reload this page.
I have noticed that this coding standard is using
PSR2.ControlStructures.ControlStructureSpacingandPSR12.ControlStructures.ControlStructureSpacingis also available. From what I can tell, the latter includes checks from the former and some additional useful checks. This pull request changes to use the new version of this sniff.Fixes YouweGit/coding-standard-magento2#6
Related to: #128