Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Only auto-fix $this to $block when safe to do #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredden wants to merge 1 commit into magento:develop
base: develop
Choose a base branch
Loading
from fredden:no-fix-this-helper

Conversation

Copy link
Member

@fredden fredden commented Jul 7, 2022

Fixes #407

Nuranto reacted with thumbs up emoji
Copy link
Member Author

fredden commented Oct 14, 2022

@svera is there something I can do to help get this merged in?

Copy link
Contributor

@magento import PR to magento-commerce/magento-coding-standard repository

Copy link
Contributor

@sinhaparul the Pull Request is successfully imported.

Copy link

Any update on this being available in the stable release of magento/magento-coding-standard? This is preventing production use without a patch 😞

Thanks,
Bruce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing $this with $block in templates is not universally safe / correct

AltStyle によって変換されたページ (->オリジナル) /