-
Notifications
You must be signed in to change notification settings - Fork 165
No longer require a space before a colon for control structures using... #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
7426521 to
77d0290
Compare
I've added a unit test, but for some reason it's not working properly. If somebody could give me a hint why not, that would be appreciated!
It might be because there is no corresponding Sniff added, but does that mean that no unit test is required in this case?
... the alternative syntax
77d0290 to
f7c47a0
Compare
I've thought about it some more and it doesn't make much sense to have unit tests for this in the magento-coding-standard repo. The unit tests should be (and are already) part of the PHP_CodeSniffer repo.
So they are removed again over here.
@hostep thank you for this improvement.
AC-391: Static test to cover "deprecated" jQuery methods
... the alternative syntax
This fixes #118
Documentation: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizcontrolstructurescontrolsignature